grnet / djnro

DjNRO hits the decks of eduroam database management
http://djnro.grnet.gr/
Other
10 stars 21 forks source link

Some fixes for Django 1.11 #58

Closed zmousm closed 5 years ago

zmousm commented 5 years ago

See individual commits

vladimir-mencl-eresearch commented 5 years ago

Hi @zmousm , thanks for these fixes (and for the review of #56) - both of these fixes look reasonable to me. Thanks for catching the Python3 spurious migration!

Cheers, Vlad

zmousm commented 5 years ago

@vladimir-mencl-eresearch please review the last commit I added.

vladimir-mencl-eresearch commented 5 years ago

Hi @zmousm ,

I've just looked at the code deep dive report in #56 and the documentation update here in 17758ab - looks all good to me.

Thanks for adding the alternative workaround - and also for the overall documentation polish, looks much better now.

Cheers, Vlad