search

grnet / djnro

DjNRO hits the decks of eduroam database management
http://djnro.grnet.gr/
Other
10 stars 21 forks source link

connect: tweak template to enable overriding selectors in the institution list #61

Closed vladimir-mencl-eresearch closed 5 years ago

vladimir-mencl-eresearch commented 5 years ago

Hi @zmousm ,

Thanks for the detailed suggestions in #60 - works for me perfectly. I've now added the suggested cat_institution_selector template block (and also bumped font-awesome to 4.7.0).

I was looking for a more suitable icon to use in our setup - I found https://fontawesome.com/icons/user-cog?style=solid, but that would require font-awesome 5, and that might be too much of an overhaul.

I'm in the end using "cogs" icon in our setup - that provides a hint to the users that this might be setting their device up.

Happy to contribute the icon bit if you in the end find it useful - but also happy just having it in a local template.

Leaving this one for you to look at (but understand this would be also OK to merge right away...)

Cheers, Vlad

zmousm commented 5 years ago

I'm happy to merge once the inline comment gets resolved. I do wonder what regressions the FA bump may bring but it's hard to tell anyway (yes this would be more difficult for a FA 5 bump).

zmousm commented 5 years ago

I'm happy to merge once the inline comment gets resolved

I did this myself. I hope you're OK with the wording. I would prefer to amend 996ee45 rather than push a new commit.

vladimir-mencl-eresearch commented 5 years ago

Thanks @zmousm - all happy with you changing the wording on my behalf.