grnet / djnro

DjNRO hits the decks of eduroam database management
http://djnro.grnet.gr/
Other
10 stars 21 forks source link

Fix font-awesome tags #75

Closed ghalse closed 4 years ago

ghalse commented 4 years ago

When font-awesome was upgraded in #61, some icons got left behind. While mostly cosmetic, this did create a functional problem with the "show password" link.

This replaces all of the legacy v3.2 icon- tags with their direct equivalents in font-awesome 4.7.0. While I was at it, I've also been through the code and found all the fa- tags and verified they still exist in 4.7.0.

Given that all font-awesome icons are now tagged with the fa class, this should make a future upgrade a bit simpler too.

zmousm commented 4 years ago

Thanks. I had noticed the discrepancy while housekeeping services_edit.html but I didn't get to fix things at the time.