zmousm
commented
4 years ago Hi @vladimir-mencl-eresearch
InstitutionDetails has a FK to Coordinates, this is why django admin shows the select widget. Per the note in docs coordinates are not fully supported (beyond ServiceLoc) yet in edumanage, ditto for django admin.
I will look into implementing something like edumanage.forms.ServiceLocForm for InstitutionDetails. The longer term approach is probably switching to GeoDjango though (after all).
Hi @zmousm , thanks for the quick turnaround on #78 !
I'm just testing this now - looks all good to me.
Just one issue persists ... and as it's not introduced in #78 but existed before, I'm creating a new issue for it.
When editing Institution's Details via Django Admin, I still get presented with a Coordinates field, which lets me select from defined Coordinates objects. It starts as blank and can be left as blank, but it would not allow me to create a new Coordinates object, just pick from existing ones.
This could be confusing (for the end-deployers / NRO admins).
I can see that an InstitutionDetails object indeed has Coordinates (as a Foreign Key), this was introduced in 9837869.
But the /manage edit Institution page does not show coordinates at all. And I can't tell whether an Institution actually should have coordinates or not.
If yes, then it should be added to the /manage page - and the DjangoAdmin interface should allow entering numeric coordinates and translate that to/from an Coordinates object, like it's done for a ServiceLocation.
If not, then it should be dropped from the model ... and then it would also disappear from the DjangoAdmin interface.
Does this make sense to you? And should InstitutionDetails have Coordinates or not?
Thanks a lot in advance for getting back to me.
Cheers, Vlad