search

grnet / djnro

DjNRO hits the decks of eduroam database management
http://djnro.grnet.gr/
Other
10 stars 22 forks source link

new: pass ATTRIB-INSTITUTION-TYPE to CAT API NEWINST call #95

Closed vladimir-mencl-eresearch closed 1 year ago

vladimir-mencl-eresearch commented 1 year ago

To exactly match inst types as expected by CAT, define these in utils/cat_helper.py.

In edumanage.views.catenroll, add ATTRIB-INSTITUTION-TYPE with the correct value to params passed to CatEnroll.newinst.

As the params passed will go through deuglify, pass the param in notation expected by deuglify.

vladimir-mencl-eresearch commented 1 year ago

Hi @zmousm , can you please have a look at this PR?

It fixes the issue discussed on Slack (DjNRO unable to create new organisations in CAT since August 2022) - and has been tested and works.

Please let me know if OK to merge.

Cheers, Vlad

zmousm commented 1 year ago

Hi @vladimir-mencl-eresearch. Indeed we somehow missed this change in CAT 2.1. This reminds me we would need to employ versioning for the CAT admin API, but anyway...

Please see the inline comment and the changes to your patch.

zmousm commented 1 year ago

I can not push to your fork branch. Please "Allow edits from maintainers". Or see the branch pr95 (diff).

vladimir-mencl-eresearch commented 1 year ago

Thanks for the quick response @zmousm !

Sorry, messed up permissions - I've merged your commits into this branch.

Happy to merge as it is now?

Cheers, Vlad