search

grnet / eidas-keycloak-extension

Keycloak Identity Provider Extension which supports the extended SAML v2.0 dialect of the European Union eIDAS Nodes.
Apache License 2.0
29 stars 8 forks source link

Missing parts for a 1.0 version #1

Open florianschiller opened 2 years ago

florianschiller commented 2 years ago

Hello,

Thank you for your great work on this plugin. We are currently looking into integrating eID into our Keycloak and stumbled upon your it. It seems to fit our needs perfectly, but we are wondering, what is missing for a release above version 1.0. Can you add some information regarding this, please? It would be great to have somekind of ToDo section in the read-me. If you need some help, we are willing to take over parts of the implementation as well.

Best regards Florian

d-michail commented 2 years ago

Hi Florian,

we have developed this plugin in the context of a European project and we have not really "battled" tested it in a production environment yet. This is the reason that we used a 0.x version. Nevertheless, we are going to use in production in a couple of months.

We plan to release a new version (again 0.x) in the next few days, due to some security updates that happened in keycloak 18.

It would be great if you are willing to test it and provide some feedback, perhaps missing features, etc.

The major TODO would be to try and extend the actual keycloak server to support custom XML properties in the SAML response payload. This would really simplify this plugin (avoid a lot of copy paste code). I opened up a thread for this in the keycloak users group but never got any answer. I can provide more info if you are interested.

Best, Dimitrios

florianschiller commented 2 years ago

Hello Dimitrios,

Thanks for your quick response. Sounds great. We are currently unable to fully test the plugin, because we are mising a eID service provider, but I'll get back to you afterwards. Could you send me a link to your thread in the user group, please? This way, we can leave our own feedback in there.

Best regards Florian

d-michail commented 2 years ago

Hi,

my inquery was https://groups.google.com/g/keycloak-dev/c/-Tb8KVsCG6E/m/U2yiPQz7BgAJ but never got any answer. They seem to have moved from jira to github for the issues, thus I will try in the next few days to open an issue there.

In short, most of the code in this plugin would not be needed if there was a way in keycloak to adjust the xml parsing that happens during the response from the eidas node.

There seems to be some progress like the following https://github.com/keycloak/keycloak/pull/10650 .

Best, Dimitrios