search

grnhse / greenhouse_io

Ruby API wrapper for Greenhouse.io API
MIT License
44 stars 46 forks source link

Add all_scorecards method #15

Closed bcoppersmith closed 8 years ago

bcoppersmith commented 8 years ago

Adding a method for the all_scorecards api endpoint, along with some tests cribbed from the scorecards endpoint. We're already using this for some scripts internally and I figured it belongs in the core gem, too.

capablemonkey commented 8 years ago

Thanks so much for the contribution, @bcoppersmith!

I'm a big fan of Factual :). Say hi to @jazzyfresh for me! :smile:

Hope you don't mind -- just going to rename this method from all_scorecards to scorecards to better match the naming style of the other methods.

capablemonkey commented 8 years ago

Ah, never mind. I understand why you named it all_scorecards now. I thought we were missing a scorecards method but it turns out we have one already and it actually returns scorecards for a given application ID. I wish it had been named scorecards_for_application or something to that effect. Oh well, we will probably fix this in the next major version.