search

grnhse / greenhouse_io

Ruby API wrapper for Greenhouse.io API
MIT License
44 stars 46 forks source link

Implement #update_application #28

Open RoxasShadow opened 7 years ago

RoxasShadow commented 7 years ago

Hello!

I had the need to update a candidate's application but I couldn't any way to do that currently as Client#applications is a GET-only method, and this is why I implemented a new specialized method called Client#update_application.

I couldn't find instructions for VCR conventions. What I did was to use my sandbox account to create them and replace the token with the fake token currently used by the other cassettes, but I'm not sure if you prefer the IDs being faked or not.

RoxasShadow commented 7 years ago

To make tests pass for ruby19 I think we should lock the rake gem in the gemspec file to an older version, but I'm not sure what's your idea about supporting versions older than ruby2 (in case there's an agreement on dropping the support for ruby19, I think that upgrading all the other gems greenhouse_io depends on would also be a good idea).