groakat / AudioTagger

5 stars 2 forks source link

Small change to display frequency in kHz #80

Closed macaodha closed 8 years ago

macaodha commented 8 years ago

Also takes into account time expansion

groakat commented 8 years ago

Hmm, the sound speed only changes the speed of the playback, it does not change anything on the histogram. The only time when the histogram is affected is when Audiotagger switches between night and day spectogram types, and then the freqs array is getting recomputed.

So I think we do not need to normalise by the speed of the playback sound.

macaodha commented 8 years ago

Some files are time expanded and some are not. With this change if you mouse over bat calls they will be at the correct frequency.

I can see that it's not ideal, but I couldn't think of an easier fix.

On 16 Oct 2016 02:10, "groakat" notifications@github.com wrote:

Hmm, the sound speed only changes the speed of the playback, it does not change anything on the histogram. The only time when the histogram is affected is when we switch between night and day spectogram types..

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/groakat/AudioTagger/pull/80#issuecomment-254035862, or mute the thread https://github.com/notifications/unsubscribe-auth/AGWhq_dv0X2TRcM-YbK8y6yKIgZgOANgks5q0emMgaJpZM4KXb9Z .

groakat commented 8 years ago

i see. I hope no one gets in trouble with this at some point…

On 16 Oct 2016, at 18:02, Oisin Mac Aodha <notifications@github.com mailto:notifications@github.com> wrote:

Some files are time expanded and some are not. With this change if you mouse over bat calls they will be at the correct frequency.

I can see that it's not ideal, but I couldn't think of an easier fix.

On 16 Oct 2016 02:10, "groakat" <notifications@github.com mailto:notifications@github.com> wrote:

Hmm, the sound speed only changes the speed of the playback, it does not change anything on the histogram. The only time when the histogram is affected is when we switch between night and day spectogram types..

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/groakat/AudioTagger/pull/80#issuecomment-254035862 https://github.com/groakat/AudioTagger/pull/80#issuecomment-254035862>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGWhq_dv0X2TRcM-YbK8y6yKIgZgOANgks5q0emMgaJpZM4KXb9Z https://github.com/notifications/unsubscribe-auth/AGWhq_dv0X2TRcM-YbK8y6yKIgZgOANgks5q0emMgaJpZM4KXb9Z> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/groakat/AudioTagger/pull/80#issuecomment-254059182, or mute the thread https://github.com/notifications/unsubscribe-auth/ADQuNgTxUCuwiRd5MpGzm2QHU_3OW-7eks5q0li4gaJpZM4KXb9Z.