search

grobie / soundcloud2000

A terminal client for https://soundcloud.com
MIT License
1.39k stars 82 forks source link

Crashes on pressing left or right when no song playing #65

Closed petems closed 9 years ago

petems commented 10 years ago

Debug log:

/opt/rubies/2.0.0-p451/lib/ruby/gems/2.0.0/gems/audite-0.3.0/lib/audite.rb:88:in `samples_per_frame': undefined method `spf' for nil:NilClass (NoMethodError)
    from /opt/rubies/2.0.0-p451/lib/ruby/gems/2.0.0/gems/audite-0.3.0/lib/audite.rb:112:in `samples_to_frames'
    from /opt/rubies/2.0.0-p451/lib/ruby/gems/2.0.0/gems/audite-0.3.0/lib/audite.rb:108:in `samples_to_seconds'
    from /opt/rubies/2.0.0-p451/lib/ruby/gems/2.0.0/gems/audite-0.3.0/lib/audite.rb:127:in `position'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/models/player.rb:77:in `seconds_played'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/models/player.rb:123:in `forward'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/controllers/player_controller.rb:30:in `block in initialize'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/events.rb:13:in `call'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/events.rb:13:in `block in trigger'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/events.rb:12:in `each'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/events.rb:12:in `trigger'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/application.rb:72:in `handle'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/application.rb:49:in `block in main'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/application.rb:47:in `loop'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/application.rb:47:in `main'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000/application.rb:65:in `run'
    from /Users/peterso/Projects/soundcloud2000/lib/soundcloud2000.rb:15:in `start'
    from /Users/peterso/Projects/soundcloud2000/bin/soundcloud2000:9:in `<top (required)>'
    from /opt/rubies/2.0.0-p451/lib/ruby/gems/2.0.0/bin/soundcloud2000:23:in `load'
    from /opt/rubies/2.0.0-p451/lib/ruby/gems/2.0.0/bin/soundcloud2000:23:in `<main>'

Probably need some sort of ignore if no song playing or something?

petems commented 10 years ago

Fixed in https://github.com/grobie/soundcloud2000/pull/67

petems commented 9 years ago

Merged in https://github.com/grobie/soundcloud2000/pull/67