grocerist / grocerist-app

Repo for Grocerist's Web-Application
https://grocerist.github.io/grocerist-app/
MIT License
1 stars 0 forks source link

persons page bar chart #214

Closed kisram closed 1 month ago

kisram commented 2 months ago

Please note that each grocery store is situated in a specific administrative unit, such as a mahalle or a karye, but not both. Therefore, the “unknown” category for the location of grocery stores is incorrect. Kindly make the necessary adjustments to reflect this accurately.

our understanding was that the location categories have the following hierarchy (from small to big): Address -> Karye -> Mahalle -> Quarter -> Nahiye -> District, so I asked about this and whether there are any other categories that are actually mututally exclusive

Locations are hierarchical; however, not every address in the document is expected to include all categories. Karye and mahalle are mutually exclusive categories, which is certain. However, we are relying on a document from the early modern period, so some exceptions are to be expected (person_70). In such cases, we can simply remove the mahalle information and categorize it under the karye section. To be honest, all location categories are meant to be mutually exclusive, but exceptions may still arise. Therefore, it might be a good idea to reconsider the approach.

For now, we'll combine Mahalle and Karye on the chart Looking at the data, all location categories being mutually exclusive is defnitely not true (at least not atp). Since the Quarter and Nahiye columns are empty or barely filled out in the Persons table, we'll remove these 2 categories from the chart for now, this should significantly reduce the overall number of "Unknown" entries.

We'll need to discuss the location categories at the next meeting, e.g. whether there is any difference between the location data in the documents table and the location data in the Person table, because if there isn't (or at least there is not supposed to be), we should just get the information for the person from the Document associated with the person and avoid having to enter the same information in two tables.

kisram commented 2 months ago

they would also like to have the Districts chart only for the 18th century, this started a conversation about whether the location data on the Person page refers to where the grocery shop was or where this person lived

kisram commented 2 months ago

answer: it was supposed to be about where they lived, but the Documents didn't consistently provide this information, so now it's basically about the location of the grocery shop. Added a century column in Baserow that calculates the century with a formula, filtering this column on the website creates the desired Districts chart for the 18th century

kisram commented 1 month ago

since we're getting the location information through the associated Documents now, there are even more people that have both Mahalle and Karye and sometimes also several different Mahalle/Karye: e.g. person__7

image

image all 3 come from a different document, but currently there is no way of seeing that on the chart, we need to figure out how to best reperesent cases like this

kisram commented 1 month ago

After trying out different things and thinking about it, I think the best solution is to just move this bar chart to the locations page. Waiting to hear back whether this is ok for them as well

kisram commented 1 month ago

they're fine with moving it, but also want to keep just a Districts chart on the Persons page