grodansparadis / node-red-contrib-socketcan

A socketcan interface
https://www.vscp.org
Other
14 stars 5 forks source link

Fix some typos #3

Closed eddso closed 3 years ago

eddso commented 4 years ago

Hi, here some typo fixes that you can apply: 1) delete '}' https://github.com/grodansparadis/node-red-contrib-socketcan/blob/1710555c9cdb6b416560c56c924f7f6372e9f352/src/send.html#L68

2) should be 'socketcan-out' https://github.com/grodansparadis/node-red-contrib-socketcan/blob/1710555c9cdb6b416560c56c924f7f6372e9f352/src/receive.html#L108

3) should be 'socketcan-out' https://github.com/grodansparadis/node-red-contrib-socketcan/blob/1710555c9cdb6b416560c56c924f7f6372e9f352/src/receive.html#L100

grodansparadis commented 4 years ago

Thanks a lot. Appreciated. Updated.

/Ake

On 2020-07-22 10:12, Eduard Neufeld wrote:

Hi, here some typo fixes that you can apply:

1.

in src/send.html, line 68, '}' need to be deleted
https://github.com/grodansparadis/node-red-contrib-socketcan/blob/1710555c9cdb6b416560c56c924f7f6372e9f352/src/send.html#L68

2.

in src/receive.html, line 106, 'socketcan-in' must be 'socketcan-out'
https://github.com/grodansparadis/node-red-contrib-socketcan/blob/1710555c9cdb6b416560c56c924f7f6372e9f352/src/receive.html#L108

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/grodansparadis/node-red-contrib-socketcan/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKLYIY7V4QUDECL7CS5TKDR42NNPANCNFSM4PEOJSLA.

-- Be Hungry - Stay Foolish! Åke Hedman, Grodans Paradis AB / Paradise of the Frog Brattbergavägen 17, 82050 LOS, SWEDEN, +46 8 40011835 http://www.grodansparadis.com http://www.vscp.org http://www.akehedman.se

eddso commented 4 years ago

Thank you for apply fix. Point 3. is stil there: https://github.com/grodansparadis/node-red-contrib-socketcan/blob/49dbc73ab62ef84067ed8d849ec71ffdf6f3adfc/src/receive.html#L100

grodansparadis commented 3 years ago

Sorry I missed that. Fixed now.