search

grodansparadis / vscp-firmware

Firmware for the VSCP project
http://www.vscp.org
28 stars 9 forks source link

Error in who is there response #13

Open grodansparadis opened 3 years ago

grodansparadis commented 3 years ago

Hi Ake,

Just a small note that I think I found a bug in the paris & beijing original firmware v1.1.5 (& potentially all derived types) on the "who's there" command response.

This is the logging I get for a who's there event on three nodes (the other 6 are behaving identical):

Tx 0,0,31,0,2020-12-19T14:35:35,0,,7 Rx 96,0,32,0,2020-12-19T14:35:35,593038244,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:07,0,2,0,0,6,0,0,0 Rx 96,0,32,0,2020-12-19T14:35:35,593038785,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:07 Rx 96,0,32,0,2020-12-19T14:35:35,593039371,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:07 Rx 96,0,32,0,2020-12-19T14:35:35,593039931,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:07 Rx 96,0,32,0,2020-12-19T14:35:35,593040507,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:07 Rx 96,0,32,0,2020-12-19T14:35:35,593041092,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:07 Rx 96,0,32,0,2020-12-19T14:35:35,593041662,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:07

Tx 0,0,31,0,2020-12-19T14:35:35,0,,8 Rx 96,0,32,0,2020-12-19T14:35:36,593095025,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:08,0,255,16,0,0,2,0,0 Rx 96,0,32,0,2020-12-19T14:35:36,593095601,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:08 Rx 96,0,32,0,2020-12-19T14:35:36,593096162,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:08 Rx 96,0,32,0,2020-12-19T14:35:36,593096754,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:08 Rx 96,0,32,0,2020-12-19T14:35:36,593097328,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:08 Rx 96,0,32,0,2020-12-19T14:35:36,593097897,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:08 Rx 96,0,32,0,2020-12-19T14:35:36,593098475,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:08

Tx 0,0,31,0,2020-12-19T14:35:35,0,,9 Rx 96,0,32,0,2020-12-19T14:35:36,593111438,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:09,0,255,15,0,0,2,0,0 Rx 96,0,32,0,2020-12-19T14:35:36,593112017,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:09 Rx 96,0,32,0,2020-12-19T14:35:36,593112576,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:09 Rx 96,0,32,0,2020-12-19T14:35:36,593113142,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:09 Rx 96,0,32,0,2020-12-19T14:35:36,593113710,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:09 Rx 96,0,32,0,2020-12-19T14:35:36,593114283,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:09 Rx 96,0,32,0,2020-12-19T14:35:36,593114853,00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:09

The number of events is correct, but the data is not present (all replies should have DLC=8). I think something is going wrong with the vscp_omsg global var during/after sending, but I don't find my way around the code.

I will not be using this firmware from tomorrow on normally, so not at all urgent for me!

By the way, do you still have some hardware modules on stock of either type?

Cheers, Maarten

grodansparadis commented 2 years ago

note to self: Add vscp_omsg.flags = VSCP_VALID_MSG + 8; before sendEvent call?