search

grodansparadis / vscp-firmware

Firmware for the VSCP project
http://www.vscp.org
28 stars 9 forks source link

Update to upstream repository #7

Closed nos86 closed 9 years ago

nos86 commented 9 years ago

Review on Reviewable

Comments from the review on Reviewable.io

   

grodansparadis commented 9 years ago

Review status: :shipit: all files reviewed, all discussions resolved, all commit checks successful. Reviewed files:

Comments from the review on Reviewable.io

nos86 commented 9 years ago

Hello,

I'm sorry, I'm a newbie with GitHub and last pull request was an error. Please, undo it, I don't want to create any glitch with other developers.

As soon as my projects will be stable, I'll send you a specific pull request with only project contents.

Thanks a lot and sorry again, Salvo

grodansparadis commented 9 years ago

Hi Salov,

are you sure. The only problem I saw was the vscp_class&type.h which is copies from the vscp_software repository and that should not be changed here and the

which I have reverted. So only your new stuff got added.

Do you want me to revert it anyway?

Cheers /Ake

Salvo Musumeci skrev den 2015-05-28 17:00:

Hello,

I'm sorry, I'm a newbie with GitHub and last pull request was an error. Please, undo it, I don't want to create any glitch with other developers.

As soon as my projects will be stable, I'll send you a specific pull request with only project contents.

Thanks a lot and sorry again, Salvo

— Reply to this email directly or view it on GitHub https://github.com/grodansparadis/vscp_firmware/pull/7#issuecomment-106380103.

Be Hungry - Stay Foolish! Åke Hedman, Grodans Paradis AB / Paradise of the Frog Brattbergavägen 17, 82050 LOS, SWEDEN Phone: +46 (0)840011835 CellPhone: +46 (0)730-533146 http://www.grodansparadis.com http://www.vscp.org

Detta e-postmeddelande har sökts igenom efter virus med antivirusprogram från Avast. http://www.avast.com

grodansparadis commented 9 years ago

The hex files for the avr latch project was removed due to .hex included in .gitignore but I have restored them again so there should be nothing else changed than the files you added now. Git can really be a mouthful sometime.

Salvo Musumeci skrev den 2015-05-28 17:00:

Hello,

I'm sorry, I'm a newbie with GitHub and last pull request was an error. Please, undo it, I don't want to create any glitch with other developers.

As soon as my projects will be stable, I'll send you a specific pull request with only project contents.

Thanks a lot and sorry again, Salvo

— Reply to this email directly or view it on GitHub https://github.com/grodansparadis/vscp_firmware/pull/7#issuecomment-106380103.

Be Hungry - Stay Foolish! Åke Hedman, Grodans Paradis AB / Paradise of the Frog Brattbergavägen 17, 82050 LOS, SWEDEN Phone: +46 (0)840011835 CellPhone: +46 (0)730-533146 http://www.grodansparadis.com http://www.vscp.org

Detta e-postmeddelande har sökts igenom efter virus med antivirusprogram från Avast. http://www.avast.com

grodansparadis commented 9 years ago

@mamac removed your he files form the latch project today by mistake. Restored now again. My fault. Just in case you wounder what is happening

nos86 commented 9 years ago

Ciao,

most important stuff is that no corrupted files are present for other users. Regarding my project, I suggest you to remove it and as soon as I have a stable version, I'll pull it in your repository.

Thanks and sorry again, Salvo

grodansparadis commented 9 years ago

No problem Salvo. I fix that. Have a nice weekend down there in the sun (I hope).

/Ake

Salvo Musumeci skrev den 2015-05-29 11:53:

Ciao,

most important stuff is that no corrupted files are present for other users. Regarding my project, I suggest you to remove it and as soon as I have a stable version, I'll pull it in your repository.

Thanks and sorry again, Salvo

— Reply to this email directly or view it on GitHub https://github.com/grodansparadis/vscp_firmware/pull/7#issuecomment-106761222.

Be Hungry - Stay Foolish! Åke Hedman, Grodans Paradis AB / Paradise of the Frog Brattbergavägen 17, 82050 LOS, SWEDEN Phone: +46 (0)840011835 CellPhone: +46 (0)730-533146 http://www.grodansparadis.com http://www.vscp.org

Detta e-postmeddelande har sökts igenom efter virus med antivirusprogram från Avast. http://www.avast.com