grofit / aurelia-chart

A chart element for aurelia which is powered by chart js using html5 canvas.
MIT License
46 stars 25 forks source link

refactor(all): typescript, upgrade to chart.js@3, use npm workspaces #40

Closed MaximBalaganskiy closed 3 years ago

MaximBalaganskiy commented 3 years ago

The main goal is to upgrade to chart.js@3, but since I looked into it anyway I took the liberty to upgrade to typescript and npm workspaces.

Cleaned out jspm and aurelia build scripts as well.

grofit commented 3 years ago

I am not too sure about a few of the editor specific things, but rest looks good. If anyone has any problems they can always push another PR detailing what they dislike about it and why etc.

grofit commented 3 years ago

While doing package bump I noticed the package.json is marked as private and has a different name aurelia-chart-monorepo, are you publishing this separately yourself or are you ok with me just removing private flag and resetting name and doing an npm publish?

MaximBalaganskiy commented 3 years ago

The actual package is in packages/aurelia-chart folder. Doing it this way allows for having a demo app as a package as well. Npm than manages the symlink to the chart package

On Thu, 15 Apr 2021 at 6:52 pm, LP @.***> wrote:

While doing package bump I noticed the package.json is marked as private and has a different name aurelia-chart-monorepo, are you publishing this separately yourself or are you ok with me just removing private flag and resetting name and doing an npm publish?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/grofit/aurelia-chart/pull/40#issuecomment-820246153, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4KNPFNM6R6UFSCV2HADMLTI2SMXANCNFSM426TZISA .

grofit commented 3 years ago

ahhhh ok, I have not used npm workspaces :D good to know they exist now though.

I will update the package version and publish that then, thanks again for the PR.

grofit commented 3 years ago

ok not as simple as I thought, what is intended build order here? I assumed:

I am getting varying errors though, I am on windows 10 not sure if that makes any issues, but I have an exam to do in a mo, so cant really delve much further til later.

If you could give me the intended build sequence I can push up new version to npm.

MaximBalaganskiy commented 3 years ago

I've cleaned up the scripts - lage is an overkill here ;) The sequence is

The version number is in two places - main package.json and aurelia-chart/package.json. You only need to update the first one you would like to automate changelog.md updates.

grofit commented 3 years ago

Right all published under 0.3.1 thanks again for help