search

grofit / dotween-nodecanvas

Node Canvas actions for DoTween library
12 stars 4 forks source link

Added camera actions #8

Closed DogeThis closed 8 years ago

DogeThis commented 8 years ago

Testing done: loaded into a test scene manually and ran them.

QA Request: Check if the actions are labelled correctly and the descriptions written clearly. In particular, I'm wondering if we want to add Camera to each of the descriptions, like

Create Shake Position Tween (Float Strength)

vs

Create Camera Shake Position Tween (Float Strength)

DogeThis commented 8 years ago

Additionally, what do you think about the DoShakePosition and DoShakeRotation shortcuts, since they are essentially the same methods as the Transform versions?

I'm aiming to support all the shortcuts on http://dotween.demigiant.com/documentation.php, but not sure if you had a different take on it.

grofit commented 8 years ago

All looks fine, its so trivial to add actions I am happy to add shortcuts so people who use it are not confused as to why certain things are missing.

One thing to note though, if they are identical but just a different name, you can always derive a new class and just give it different attributes and that should work instead of having to copy and paste the same logic 3 times, also means less code to maintain.