search

grofit / playmaker-astar-actions

Playmaker Astar Pathfinding Actions
5 stars 4 forks source link

The FsmDummy objects conflict with the real instances in the pro version #3

Closed grofit closed 10 years ago

grofit commented 10 years ago

When importing the project into a project with the pro version of the A* system there will be conflicts with the FsmDummies and the real implementations, I think the solution is to have 2 releases, one for the pro version which does not contain the dummies and one for the free version which does.

kiriri commented 10 years ago

I started it off that way and it just got confusing. I would like to keep both pro and free in one project. The installer will take care of it once it's rewritten to no longer restructuate the astar folders. This way we can also avoid all those issues people get when they update their projects.

Cheers, Sven On Nov 7, 2013 9:26 AM, "Lee Prosser" notifications@github.com wrote:

When importing the project into a project with the pro version of the A* system there will be conflicts with the FsmDummies and the real implementations, I think the solution is to have 2 releases, one for the pro version which does not contain the dummies and one for the free version which does.

— Reply to this email directly or view it on GitHubhttps://github.com/grofit/playmaker-astar-actions/issues/3 .

grofit commented 10 years ago

If we are going down the route of just having project exports in the /dist directory its not too much of a bother, lots of other libraries do it this way. For me I dont see why it needs an installer, its just more work for you to maintain it and more work for the user to do. Almost every other unity library I have ever used (not used that many) just gives you an import package which makes things easier.

If there is some benefit to having a custom installer rather than just a standard unity importer then I am happy to think about it some more, but I currently cannot see any real benefit, but multiple downsides.

kiriri commented 10 years ago

The thing is,so far the installer has really helped avoid any questions on the forums regarding updates etc. It only needs changing if one adds new folders, or if the folder structure of the A* plugin changes. In exchange, it allows one to really change the entire structure of the plugin (eg remove scripts, rename them) without any need for the user to remove old scripts manually to get the project working. This is especially useful in this project where most users do not even understand the log messages (I'm speaking from experience here).

Of course we can also just provide both the .unitypackage and the installer at the same time. We won't have to change anything about the filler scripts (the one the free version needs), so if you have a pro version we can just remove them from the package and add them as a zip to the description. Then we'd have just one project and could test the pro features too (This is how I always had my project set up before). On Nov 7, 2013 9:39 AM, "Lee Prosser" notifications@github.com wrote:

If we are going down the route of just having project exports in the /distdirectory its not too much of a bother, lots of other libraries do it this way. For me I dont see why it needs an installer, its just more work for you to maintain it and more work for the user to do. Almost every other unity library I have ever used (not used that many) just gives you an import package which makes things easier.

— Reply to this email directly or view it on GitHubhttps://github.com/grofit/playmaker-astar-actions/issues/3#issuecomment-27945799 .

grofit commented 10 years ago

Personally I am not too fussed, like you say its easy enough now to extract the bits needed for pro/free if someone does need an importer package rather than the installer, only thing I ask is that we leave the actions in their own folder in the source code so it remains easy enough to extract them for doing it this way.

kiriri commented 10 years ago

sure thing, glad that's settled then :)

On Thu, Nov 7, 2013 at 12:12 PM, Lee Prosser notifications@github.comwrote:

Personally I am not too fussed, like you say its easy enough now to extract the bits needed for pro/free if someone does need an importer package rather than the installer, only thing I ask is that we leave the actions in their own folder in the source code so it remains easy enough to extract them for doing it this way.

— Reply to this email directly or view it on GitHubhttps://github.com/grofit/playmaker-astar-actions/issues/3#issuecomment-27954524 .