Update to version 3.4 of Astar project

grofit commented 10 years ago

I have done as much as I can on this one without tinkering with the core logic, I have assigned it to you to do the remaining refactoring if that is ok as I do not know the effects of removing certain methods (which now seemingly have vanished or are deprecated).

HalfVoxel commented 10 years ago

I'm here if you want to ask anything about the API : )

-- Aron Granberg

grofit commented 10 years ago

Oh brilliant, I dont have my laptop with me at the moment but I think there are about 40 odd errors around 3 main areas in the branch we have. I think the errors revolved around properties which no longer exist (which may not be required anymore) and the creating of nodes (as previously it used the CreateNodes with the returned nodes being utilized).

I can provide more information when I get back to the office, or if you are feeling adventurous check out the 3.4 branch and have a quick look over.

To be fair you answered most of my main queries in the question raised on your forum, so I am hoping Kiriri will take a look at it and just cut away the stuff which is redundant.

kiriri commented 10 years ago

Hey,

Thank you for being so helpful Aron !

I downloaded the project as a zip now(Because I don't want to risk any push problems again, I had to discard some work last I tried) and will work on it today or tomorrow. I'm sorry for not having found the time to do it earlier, not having any internet at home is a bit of a bummer :D

Cheers, Sven

On Wed, Dec 18, 2013 at 2:58 PM, Lee Prosser notifications@github.comwrote:

Oh brilliant, I dont have my laptop with me at the moment but I think there are about 40 odd errors around 3 main areas in the branch we have. I think the errors revolved around properties which no longer exist (which may not be required anymore) and the creating of nodes (as previously it used the CreateNodes with the returned nodes being utilized).

I can provide more information when I get back to the office, or if you are feeling adventurous check out the 3.4 branch and have a quick look over.

To be fair you answered most of my main queries in the question raised on your forum, so I am hoping Kiriri will take a look at it and just cut away the stuff which is redundant.

— Reply to this email directly or view it on GitHubhttps://github.com/grofit/playmaker-astar-actions/issues/5#issuecomment-30843077 .

grofit commented 10 years ago

Sorry for the delay in posting errors:

GraphNode.UpdateNeighbourConnections <- No longer seems to exist, not sure if I can just cull this code
GraphNode.UpdateConnections <- Same, not sure if this can be deleted
GraphNode.connections <- Doesn't exist now seems to be used as a callback on GetConnections, however it is used as a list, so not sure how performant it would be rebuilding the list from the callbacks
GraphNode.nodes <- This one we have kinda solved, but in the areas where it is used as a list to be passed around you are manually rebuilding the list/array each time which I would say is unperformant as it would be individual allocations not bulk (reftype vs valuetype) like mentioned in previous issue
GridGraph.getNearestForceOverlap <- This now seems to be static and I cannot find a suitable way to call it as it seemed to be assigned against the instance currently

That are the main ones, if anyone has any ideas I am happy to do the legwork. The main concern for me is that rebuilding the lists/arrays constantly would be a bit slow due to the memory allocation for the new list. If it was all value objects it would be a lot quicker as I could bulk allocate the memory then, but as they are all ref types not much can be done to optimise it. So if you can think of any pattern to use, especially for NavGraph etc which does not expose the underlying nodes (as per change requested as an interim in the original forum post)

grofit commented 10 years ago

Anyone able to indicate the right course of action on the above yet?

grofit commented 10 years ago

points above need some direction gentlemen, anyone want to give any steering the guys in the forum are starting to comment on lack of support for the latest version.

grofit commented 10 years ago

@HalfVoxel @kiriri Hey guys just seeing if you have made any progress, I will just continue to bump every 2 weeks from here on.

kiriri commented 10 years ago

Sorry for not checking the commits, but all my programming work, even the commercial projects are off atm. I need to focus all my energy on my studies. I will be able to get back to programming in about 2 months I hope. On Jan 25, 2014 12:01 PM, "Lee Prosser" notifications@github.com wrote:

@HalfVoxel https://github.com/HalfVoxel @kiririhttps://github.com/kiririHey guys just seeing if you have made any progress, I will just continue to bump every 2 weeks from here on.

— Reply to this email directly or view it on GitHubhttps://github.com/grofit/playmaker-astar-actions/issues/5#issuecomment-33286403 .

HalfVoxel commented 10 years ago

Hi

Sorry, I do not have that much time at the moment either. I am super busy with a lot of other projects, I barely have any time to work on the A* Pathfinding Project either.

Ping me in a while so I don't forget about it and I will try to find time to fix these bugs.

grofit commented 10 years ago

Not really bugs as such just refactors required for the new version. I have informed the community there wont be any updates to this for a while.

grofit / playmaker-astar-actions

Update to version 3.4 of Astar project #5