search

groggyegg / plugin.video.dramacool

Watch Asian Drama and Korean Show with English subtitles on DramaCool.
MIT License
29 stars 14 forks source link

Minor ease of use updates #41

Closed MoojMidge closed 1 year ago

MoojMidge commented 1 year ago

Made a few changes to make this plugin a little easier to use for me:

PR for your consideration.

Requires changes to xbmcext: https://github.com/groggyegg/script.module.xbmcext/pull/1

groggyegg commented 1 year ago

I will put this on hold, I'm not sure if I want this integrated as the list would need to be maintained when any server gets added or removed which I am reluctant to do.

MoojMidge commented 1 year ago

Fair enough.

Note though, that the list of servers in the PR is just used to pick a preferred server from the list of servers scraped from the site.

If the preferred server doesn't exist, or the list of servers on the site changes, this will still be scraped and presented to the user as a list where they can select which server to use so there is no real need to update the addon, it would just function the same way it currently does without the preferred server being used.

This actually already happens because not all series, especially older ones, have the same available servers. So if a preferred server is selected that is not available for a series, the server list is just shown as normal, for the user to select and play the video.

Shall I just close the PR? Or maybe I can add an additional setting where the user can type in their preferred server name in addition to choosing one of the pre-defined servers? This way the user can always change their preferred server to reflect what is shown on the site, if it does change.

groggyegg commented 1 year ago

You can leave it open, I will look into it when I have time, probably around late December when I have vacation. Some parts of the code could be added but not sure about the rest.

Regarding preferred server, if you want it to be merged then either you or someone else have to keep it updated in repository. Since issues will probably be created when server does not exist in the list. And also needs to remove old server.

MoojMidge commented 1 year ago

All good, I can always maintain this for personal use, so no issues if you don't wan't to merge some, or all of this.

When you have a chance to review further, you can see what happens when the preferred server is not available.

As mentioned, there is no error that occurs, or any issue which will require regular changes/additions/removals from the preferred server list - the scraped server list is always used and presented to the user if the preferred server cannot be found - exactly the same as what happens now.

The preferred server selection is optional anyway, so it can just be turned off, and the scraped server list will always be shown.

When I have a bit more time, I will add a custom preferred server option anyway, so that a preferred server name can be typed in by the user if something changes, in addition to selecting from a pre-defined list.

groggyegg commented 1 year ago

Closing this since it will most likely not be merged.