search

groggyegg / plugin.video.dramacool

Watch Asian Drama and Korean Show with English subtitles on DramaCool.
MIT License
35 stars 15 forks source link

Dramacool doesn't work on kodi 20 rc2 #45

Closed cbizzle14 closed 1 year ago

cbizzle14 commented 1 year ago

Not my log as I'm not on rc2 yet but it's supposedly coming to xbox so I'll put this here before it's too late.

https://paste.kodi.tv/wiwicopalo

groggyegg commented 1 year ago

Thanks, it will be fixed in the next release.

aarontanx commented 1 year ago

Google play store has updated kodi to v20 and this plugin is broken now

groggyegg commented 1 year ago

Google play store has updated kodi to v20 and this plugin is broken now

It will be released once the testing is done. Currently there is some bugs found so there will be a delay. And I still need to test the addon with Kodi 18.

cbizzle14 commented 1 year ago

Just putting this out there. Xbox got fully updated to kodi 20 and dramacool is working for me. I've watched 3 episodes so far with no problems

groggyegg commented 1 year ago

Seems to be different between platform. Anyway, ETA for the next version is probably 21-22/01.

megazone23 commented 1 year ago

Just putting this out there. Xbox got fully updated to kodi 20 and dramacool is working for me. I've watched 3 episodes so far with no problems

It looks like it is related to the version of python. I have tried both Android and Windows versions of Kodi 20 and it seems on Windows the python version is 3.8. This problem seems to happen on a later version of python my guess is on Android it is using python 3.11.

@groggyegg thanks for all of the work on this plugin!!!

ameizeing commented 1 year ago

Is this python error in Kodi 20 the same problem highlighted by Dev of Umbrella addon? https://github.com/xbmc/xbmc/issues/22344 Workaround done for Umbrella & Fen addons, until Kodi team addresses the bug in python 3.11, is to replace ElementTree with Minidom

Mycodes2 commented 1 year ago

Thank you can't wait for the update

groggyegg commented 1 year ago

Is this python error in Kodi 20 the same problem highlighted by Dev of Umbrella addon? xbmc/xbmc#22344 Workaround done for Umbrella & Fen addons, until Kodi team addresses the bug in python 3.11, is to replace ElementTree with Minidom

Probably unrelated. Errors from the log indicate that the issue is python version.

umbrellaplug commented 1 year ago

Is this python error in Kodi 20 the same problem highlighted by Dev of Umbrella addon? xbmc/xbmc#22344 Workaround done for Umbrella & Fen addons, until Kodi team addresses the bug in python 3.11, is to replace ElementTree with Minidom

Probably unrelated. Errors from the log indicate that the issue is python version.

This is the exact issue we used minidom instead of element tree to avoid using the broken element until it could be fixed.

groggyegg commented 1 year ago

Is this python error in Kodi 20 the same problem highlighted by Dev of Umbrella addon? xbmc/xbmc#22344 Workaround done for Umbrella & Fen addons, until Kodi team addresses the bug in python 3.11, is to replace ElementTree with Minidom

Probably unrelated. Errors from the log indicate that the issue is python version.

This is the exact issue we used minidom instead of element tree to avoid using the broken element until it could be fixed.

The error from OP is related to inspect missing a deprecated method and that has nothing to do with ElementTree 🙂

`2022-12-27 17:44:53.167 T:21432 error : EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

Mycodes2 commented 1 year ago

Thank you for your time, don't know how to go about fixing it, I'm not savvy with kodi 😞 I'll just wait till hopefully they fix the bug 🙏🏽

Mycodes2 commented 1 year ago

It working now 😘😘😘👏🏽👏🏽👏🏽thank you so much