search

groggyegg / plugin.video.dramacool

Watch Asian Drama and Korean Show with English subtitles on DramaCool.
MIT License
35 stars 14 forks source link

Feature Request: TMDB integration #58

Open rahaaatul opened 1 year ago

rahaaatul commented 1 year ago

Description

I kindly request the integration of your addon with TMDB, a widely-used movie and TV show information database. This integration would serve to automate the process of finding artwork for dramas and improve the naming accuracy by fetching data from TMDB. Furthermore, it would provide additional valuable information such as ratings, plot details, and cast information.

Benefits of Integration

Artwork: TMDB can automatically retrieve high-quality artwork, enriching the visual experience for users.

Naming: Integrating with TMDB would enable your addon to fetch accurate naming information for dramas.

Ratings: Displaying ratings from TMDB can assist users in quickly assessing the quality and popularity of each drama. This information would be valuable in helping users make informed decisions about what to watch next.

Additional Information: By fetching plot summaries and cast details from TMDB, your addon can provide users with comprehensive information about each drama. Additionally, it would be incredibly useful to link the cast members with Dramacool's popular stars, allowing users to explore related content more efficiently.

Conclusion

I believe that implementing this integration will significantly enhance the usability and convenience of your addon. It would streamline the process of finding and organizing dramas, providing users with a more immersive and satisfying experience.

Thank you for considering this feature request. I appreciate your dedication to improving the addon and your responsiveness to user feedback. I look forward to seeing the continued growth and success of your project.

This is my setup now (Okay artwork & Bad Titles):

Screenshot (5)

groggyegg commented 1 year ago

Hi, thanks for the proposal. I just have a few questions regarding it.

rahaaatul commented 1 year ago
  • Do you know if there exist any addon or library that can be used for fetching these information?

Maybe TMDB Helper could fetch the information for your addon.

  • Also, do you know if there is any restrictions to their API?

They rate limit somewhere in 50 requests per second range. . I don't think there's much restrictions.

Also, I found a really cool and useful website like TMDB but for Asian Dramas! You could scrape their top airing/upcoming/popular shows for aesthetics and link them automatically by their name with dramacool contents.

Screenshot_2023_0708_224236

I'm sorry, I've never developed a Kodi addon in my life, I'm sorry I couldn't help you much as I wanted to. But I'm sure you can do it!

mrgsi commented 1 year ago

Might be easier to create a player.json for jurialmunkey's TMDB-Helper which would pull TMDB meta data, then search for the video with the dramacool add-on. The only issue would be unique Asian titles that haven't been added to the database at themoviedb.org. I can host a player I just don't know how to code it. https://github.com/mrgsi/tmdbh.players/tree/master

Wolfmasternas commented 1 year ago

Anybody knows how to install it on kodi Nexus 20.2 ? Please reply

mrgsi commented 1 year ago

Anybody knows how to install it on kodi Nexus 20.2 ? Please reply

https://github.com/groggyegg/groggyegg.github.io/blob/master/README.md

Wolfmasternas commented 1 year ago

Anybody knows how to install it on kodi Nexus 20.2 ? Please reply

https://github.com/groggyegg/groggyegg.github.io/blob/master/README.md

The Lime repository(zip) is installing correctly. But when i click install from repository and then click lime addon it gives me error

mrgsi commented 1 year ago

What is the error? I just tried it myself and it installed with no issues on Kodi 20.2. I'm thinking you could have a dependency failing. That isn't uncommon when installing a new add-on. If that is the case you can manually install the dependency by going to the add-on and clicking dependencies to find it on the list. Once that is installed you can go back and install the add-on. It should tell you in the error messages. I know error messages flash really quick.

Wolfmasternas commented 1 year ago

What is the error? I just tried it myself and it installed with no issues on Kodi 20.2. I'm thinking you could have a dependency failing. That isn't uncommon when installing a new add-on. If that is the case you can manually install the dependency by going to the add-on and clicking dependencies to find it on the list. Once that is installed you can go back and install the add-on. It should tell you in the error messages. I know error messages flash really quick.

Screenshot_20230713_071134

This kind of error is showing

groggyegg commented 7 months ago

Summary:

In order for this to work

rahaaatul commented 7 months ago

Can't believe, it's been this long, and mrgsi retired.

Wouldn't it be easier to somehow get data from tmdb-helper? You could ask the dev for some help, I guess.

If you don't want to, I guess your plan works too. I'm just happy you're considering it to work on. Because it just looks ugly without the proper thumbnail and posters.

To tackle that, I myself now maintaining 3 drama lists on trakt:

Anyone can add it as widgets in their Kodi build (I'll share mine later) and you can also play them directly with Dramacool addon, thanks to @groggyegg for adding the feature requested here.

They look great now, but updating them manually is a hassle. I wish trakt made it free to collaborate in lists.

groggyegg commented 6 months ago

Wouldn't it be easier to somehow get data from tmdb-helper? You could ask the dev for some help, I guess.

Not possible as far as I know. The only way to retrieve the data is for skinning.

groggyegg commented 5 months ago

It seems that TMDB does not have all the shows in dramacool and also the naming is a bit different which makes it a bit complicated to match. So I will probably not spend too much time on that. Instead, I have added a route to support TMDB Helper instead.

dramacool.json

hcgiub001 commented 2 months ago

hey thanks for making a player for tmdbhelper. I got really excited when I found you have a player, this isn't in the gplayers that everyone is using. I was hoping you would be kind enough to help me here

I'm not a coder, been using microsoft copilot to use your path in the player to make me a script

it came up with this

import xbmc
import xbmcgui

def get_episode_info():
    episode_info = {}
    episode_info['showname'] = xbmc.getInfoLabel('ListItem.TVShowTitle')
    episode_info['year'] = xbmc.getInfoLabel('ListItem.Year')
    episode_info['season'] = xbmc.getInfoLabel('ListItem.Season')
    episode_info['episode'] = xbmc.getInfoLabel('ListItem.Episode')
    return episode_info

def play_episode():
    episode_info = get_episode_info()
    showname = episode_info['showname']
    year = episode_info['year']
    season = episode_info['season']
    episode = episode_info['episode']

    # Construct the search URL
    search_url = f'plugin://plugin.video.dramacool/search?title=%22{showname}%22&year={year}'

    # Log the search URL
    xbmc.log(f'Search URL: {search_url}', xbmc.LOGINFO)

    # Map the final URL
    final_url = f'plugin://plugin.video.dramacool/{showname.replace(" ", "-").lower()}-{year}-episode-{episode}.html'

    # Log the final URL
    xbmc.log(f'Final URL: {final_url}', xbmc.LOGINFO)

    if xbmc.getCondVisibility('System.HasAddon(plugin.video.dramacool)'):
        xbmc.executebuiltin(f'PlayMedia({final_url})')
    else:
        xbmcgui.Dialog().notification('Error', 'DramaCool plugin not found', xbmcgui.NOTIFICATION_ERROR)

# Call the function to play the episode
play_episode()

I've been messing with this for a while. It works some times and other times it does not, says can't connect to domain. I'm only doing this for shows right now then plan to work on movies the shows it does work for, I don't get a popup to pick the stream option after, It would be better if I figured that out too.

I plan to approach Fen Lite dev and ask him a feature request. If the movie is asian but not animation and it fails to find a source, then it should use this path to get stream from dramacool. tmdbplayer can;t do that, it has fallback but any movie you ask fen lite will try to resolve, as long as it tries, it doesn't matter if it doesn't find a result. it won't go to fall back option. whereas Fen Lite can code it in himself. if a movie doesn't bring an option then fallback on dramacool. cool right?

but for my own personal needs I would love to understand why the script isn't working. it should be straight forward with your player information. it works 100% in tmdbhelper. any help would be appreciated thanks. also dramacool is best kdrama addon!