search

groggyegg / plugin.video.dramacool

Watch Asian Drama and Korean Show with English subtitles on DramaCool.
MIT License
30 stars 14 forks source link

2.0 new dialogue is broken on Confluence based skin. #8

Closed oldpoem closed 3 years ago

oldpoem commented 3 years ago

In new 2.0 and Matrix. For any confluence based skin, select "Drama list" option would pop up tiny window for filters. But whatever picked won't be execute because OK button went out of bound and no matter blind remote clicks won't exceute list command.

No ptoblem on Estuary skin though.

groggyegg commented 3 years ago

Ok, that was something I was worried about when working with custom filter dialog. Could you provide some of the skin name that has this problem? I will check it out when I have the time.

oldpoem commented 3 years ago

Ok, that was something I was worried about when working with custom filter dialog. Could you provide some of the skin name that has this problem? I will check it out when I have the time.

I tried Confluence skin and Aeon Nox Silvo both has this problem. Both are available on official kodi repo.

groggyegg commented 3 years ago

A temporary fix has been added 063ae740b0ca898bef6057116be981e093d404e7, which shows the dialog in estuary skin. Adapting the dialog to the current skin seems to be a bit difficult since different skins uses different naming in templates.

oldpoem commented 3 years ago

Tested on Confluence skin. The ok button is showed and can be select. But return no results. 1.8.5 on Kodi18 works fine so it's not server issue.

groggyegg commented 3 years ago

I can't reproduce the issue. Did you test with version 2.0.1? What is the steps you used to trigger the issue? Repository updates regularly at 00:00 UTC+2 and might not have the latest version yet.

oldpoem commented 3 years ago

I tested with 2.0.1 and with these chains give relative results.

Drama list - Japanese Drama - Filter by Char = Works OK Drama list - Japanese Drama - Filter by Year = Return no results. Drama list - Japanese Drama - Filter by Genres = Error Dialog Popup Drama list - Japanese Drama - Filter by Status = Works OK

I mainly use Filter by year. That's why I encountered no results.

groggyegg commented 3 years ago

There were some issue with the parser but it should be fixed now in 35c93cc7b10f96c90acf93c3f69df79d2694a338.