search

grokability / kandji2snipe

MIT License
26 stars 15 forks source link

Conflict with Model Names & Different Model Identifiers #23

Open smatthews0 opened 1 month ago

smatthews0 commented 1 month ago

I've noticed an issue where Model Names can cause conflicts where the Model Identifier differ and was failing the script out.

Model:MacBook Pro (16-inch, 2023) Model Identifier:Mac14,10 M2 Pro

Model:MacBook Pro (16-inch, 2023) Model Identifier:Mac14,6 M2 Max

I was getting the failure 2024-09-23 16:51:44 - INFO - Processing entry 3 out of 151 - Device Name: * - Device ID: *** 2024-09-23 16:51:44 - INFO - Could not find a model ID in Snipe-IT for: MacBook Pro (16-inch, 2023) Traceback (most recent call last): File "", line 790, in create_snipe_model(newmodel) File "***", line 558, in create_snipe_model modelnumbers[jsonresponse['payload']['model_number']] = jsonresponse['payload']['id']


TypeError: 'NoneType' object is not subscriptable

Adding a new Model with the Model Identifier bypassed the error
smatthews0 commented 1 month ago

Looks like it's something that specifically started happening with M2+? Happens with M3s as well.

2024-09-23 17:44:59 - INFO - Could not find a model ID in Snipe-IT for: MacBook Pro (16-inch, Nov 2023) Traceback (most recent call last): File "", line 790, in create_snipe_model(newmodel) File "", line 558, in create_snipe_model modelnumbers[jsonresponse['payload']['model_number']] = jsonresponse['payload']['id']


TypeError: 'NoneType' object is not subscriptable

Model Name: MacBook Pro (16-inch, Nov 2023)
Model Identifier: Mac15,9

Model Name: MacBook Pro (16-inch, Nov 2023)
Model Identifier: Mac15,7
snipe commented 1 month ago

That validation bug was fixed in Snipe-IT already. If you update to latest on master Snipe-IT, can you let me know if you're still seeing this issue?

smatthews0 commented 1 month ago

That validation bug was fixed in Snipe-IT already. If you update to latest on master Snipe-IT, can you let me know if you're still seeing this issue?

Our Snipe Instance is on Snipe-IT version:v7.0.11 build 14904 (g6c0cf9447) but it's hosted for us So I'll need to take a look. It is fixed in 7.0.12?

snipe commented 1 month ago

It is fixed in 7.0.12?

Yep - should be. Can you send an email to support@snipeitapp.com with your hosted subdomain so we can get you updated to latest?