no szip formula

[ipatch]

homebrew-freecad ci is failing using this mojave tap as homebrew-core due to szip.rb formula dependency 🤷‍♂️

---

https://github.com/FreeCAD/homebrew-freecad/runs/6265538531?check_suite_focus=true#step:17:1669

[ipatch]

and searching the commit history for szip it looks like it got replaced by libaec at some point

[ipatch]

https://github.com/Homebrew/homebrew-core/issues/96930

[ipatch]

not sure if adding an entry to formula_renames.json might resolve this issue

[gromgit]

It might or might not, but since the intent of this repo is to mirror the main Homebrew core as closely as possible, I won't be modifying any config files except where absolutely necessary.

Sorry, but you'll have to change the dependency on the FreeCAD side--you'd have to do so for everyone using the main Homebrew core anyway.

[ipatch]

i was trying to avoid setting up another fork of another repo 🙃 but your previous response made my decision easier for me.

either way since you're attempting mirror the upstream counterpart of this repo ie, homebrew/homebrew-core and have this "fork" work with mojave you're going to run into some issues with the current state of this repo one way or another.

doing a quick grep through this repo at its current state for sizp yields

rg --fixed-strings -- 'szip'
formula_renames.json
140:  "szip": "libaec",

Formula/vtk.rb
46:    depends_on "szip"

Formula/libaec.rb
21:  # These may have been linked by `szip` before keg_only change

Formula/vtk@8.2.rb
45:    depends_on "szip"

Formula/cdo.rb
23:  depends_on "szip"
32:      --with-szlib=#{Formula["szip"].opt_prefix}

Formula/cgns.rb
22:  depends_on "szip"

Formula/pdal.rb
30:  depends_on "laszip"

Formula/laszip.rb
1:class Laszip < Formula
3:  homepage "https://laszip.org/"
4:  url "https://github.com/LASzip/LASzip/releases/download/3.4.3/laszip-src-3.4.3.tar.gz"
10:    root_url "https://github.com/gromgit/homebrew-core-mojave/releases/download/laszip"
24:    system ENV.cxx, pkgshare/"example/laszipdllexample.cpp", "-L#{lib}",
25:                    "-llaszip", "-llaszip_api", "-Wno-format", "-ldl", "-o", "test"

Formula/caffe.rb
32:  depends_on "szip"

on my local system. so anybody using this repo with homebrew/homebrew-test-bot will eventually run into above mentioned error if their formula crosses paths with any of the formula in the above results.

it looks the szip formula was never properly deprecated upstream, it seems like the maintainers just decided to remove references of it, even though there are tap migrations and formula renames.

just my two cents.