grommet / grommet-cli

Deprecated, use create-react-app for v2 instead. Command Line interface for grommet
Apache License 2.0
28 stars 18 forks source link

test failed with vanilla app #14

Closed bmperrea closed 7 years ago

bmperrea commented 7 years ago

dev version worked. I'm using 2.1.4 with all of the defaults on Windows, just trying to follow this video. The server is running after calling npm run dev-server [again the dev version seems totally functional; I am having problems with the distribution version but that may be another story].

test

alansouzati commented 7 years ago

Interesting. this error makes totally sense and I'm not sure why I'm not able to reproduce it locally (I'm on a mac).

I will make sure to add these entries to the .eslintrc globals entry.

I believe this is how the .eslintrc should look like in the upcoming 2.1.5 version. I'm sorry about that.

{
  "extends": "airbnb",
  "env": {
    "node": true,
    "es6": true
  },
  "globals": {
    "it": true,
    "expect": true,
    "describe": true,
    "jest": true,
    "document": true,
    "test": true,
    "window": true,
    "fetch": true,
    "WebSocket": true,
    "alert": true
  },
  "rules": {
    "react/jsx-filename-extension": 0,
    "react/forbid-prop-types": 0,
    "react/jsx-boolean-value": 0,
    "react/jsx-first-prop-new-line": 0,
    "react/jsx-closing-bracket-location": 0,
    "react/no-multi-comp": 0,
    "react/prefer-stateless-function": 0,
    "import/no-unresolved": 0,
    "import/no-extraneous-dependencies": 0,
    "import/extensions": 0,
    "import/first": 0,
    "import/no-dynamic-require": 0,
    "jsx-quotes": ["error", "prefer-single"],
    "no-alert": 0,
    "no-use-before-define": 0,
    "no-console": 0,
    "no-tabs": 0,
    "no-param-reassign": 0,
    "no-underscore-dangle": 0,
    "comma-dangle": 0,
    "no-return-assign": 0,
    "no-plusplus": 0,
    "global-require": 0
  }
}
bmperrea commented 7 years ago

That worked. Thanks again! This is giving me a better idea of what depends on what. :)

I'll let you close this when 2.1.5 rolls out.

alansouzati commented 7 years ago

Done, https://github.com/grommet/grommet-cli/commit/638d7fe64dd4749aff8160392960278505d39b69

Thanks for reporting this!