search

grommet / grommet-cli

Deprecated, use create-react-app for v2 instead. Command Line interface for grommet
Apache License 2.0
28 stars 18 forks source link

Add '--nobrowser' option for 'pack' command #29

Closed KACAH closed 7 years ago

KACAH commented 7 years ago

Added new option '--nobrowser' for grommet pack command. This options allows to start development server without running browser on first compilation. Browser opening is anoying when developing in virtual machine and using host or remote browser to check results. Case is a bit specific, but extra flexibility could be usefull.

KACAH commented 7 years ago

You did't answer on my questions about your review, so I simply added requested changes:

  1. --nobrowser changed to --skip-open.
  2. Passed full options to build().

If you have more suggestions, plz let me know.

alansouzati commented 7 years ago

thanks for your contribution! sorry for taking such a long time to get back to you on this.