search

grommet / grommet-cli

Deprecated, use create-react-app for v2 instead. Command Line interface for grommet
Apache License 2.0
28 stars 18 forks source link

grommet check lint also JSX 💭 #34

Closed leomoreno closed 7 years ago

leomoreno commented 7 years ago

Hi, I start using grommet recently and came up with some weird situation. The test command that under the hood runs grommet check is not linting my .jsx files.

Digging a bit I found the situation is caused apparently by this line on check command:

eslintChild.send('**/*.js');

Am I missing something here? 🤔 Is there a way to tell eslint to check also .jsx files?

alansouzati commented 7 years ago

good point. sorry for taking such a long time to get back to you on this. are you up for a pull request to change this expression to also handle JSX extensions ?

eslintChild.send('**/*.jsx?');

I believe this will work :)

elmorenocivitas commented 7 years ago

Just let me get back from holidays and I'll issue a PR :)

alansouzati commented 7 years ago

nice! thank you very much