grommet / grommet-cli

Deprecated, use create-react-app for v2 instead. Command Line interface for grommet
Apache License 2.0
28 stars 18 forks source link

Project created by `grommet new` command does not work #8

Closed OlegZee closed 7 years ago

OlegZee commented 7 years ago

Here's what I get immediately after project is created:

C:\projects\2look@\sample-app>gulp dev
[01:39:24] Requiring external module babel-register
[01:39:25] Using gulpfile C:\projects\2look@\sample-app\gulpfile.babel.js
[01:39:25] Starting 'dev-preprocess'...
[01:39:25] Starting 'preprocess'...
[01:39:25] Starting 'clean'...
[01:39:25] Finished 'clean' after 1.73 ms
[01:39:25] Starting 'generate-icons'...
[01:39:25] Finished 'generate-icons' after 19 μs
[01:39:25] Starting 'jslint'...
[01:39:25]
C:\projects\2look@\sample-app\src\js\components\TodoAppDashboard.js
  7:8  error  'Section' is defined but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)
OlegZee commented 7 years ago

And here's what I see after fixing the issue above:

  [458] ./~/react-hot-loader/makeExportsHot.js 1.69 kB {0}
  [459] ./~/react-hot-loader/isReactClassish.js 801 bytes {0}
  [460] ./~/react-hot-loader/isReactElementish.js 288 bytes {0}

ERROR in ./src/js/index.js
Module not found: Error: Cannot resolve module 'react/lib/ReactMount' in C:\projects\2look@\sample-app\src\js
 @ ./src/js/index.js 1:305-336

ERROR in ./src/js/components/TodoAppDashboard.js
Module not found: Error: Cannot resolve module 'react/lib/ReactMount' in C:\projects\2look@\sample-app\src\js\components
 @ ./src/js/components/TodoAppDashboard.js 1:305-336
webpack: bundle is now VALID.
alansouzati commented 7 years ago

Thanks for reporting this, I'm as of this moment working on fixing this issue after React 15.4.0 has been released.

See this: https://github.com/facebook/react/issues/8312

And this:

https://github.com/gaearon/react-hot-loader/issues/417

OlegZee commented 7 years ago

@alansouzati Thank you! I followed your instructions as in https://github.com/grommet/grommet/issues/1059 and man it fixed my troubles. Also worth noting I was using yarn.

alansouzati commented 7 years ago

yarn is just awesome, I'm using it as well 🎉