search

grommet / grommet-cli

Deprecated, use create-react-app for v2 instead. Command Line interface for grommet
Apache License 2.0
28 stars 18 forks source link

Investigate grommet-cli + grommet-toolbox merger #9

Closed alansouzati closed 7 years ago

alansouzati commented 7 years ago

Start investigating the process of moving away from gulp as a task runner and use node to create the tasks we currently have in grommet-toolbox as part of that grommet-cli.

The idea is to install grommet globally and have the ability to run grommet copy instead of gulp copy. This is the same of all other tasks and pipelines.

RyanCCollins commented 7 years ago

@alansouzati would the idea be to keep using gulp behind the scenes, but make the same commands available through the grommet-cli interface, or would we be redoing the functionality of grommet-toolbox to get away from Gulp altogether?

alansouzati commented 7 years ago

The idea is to remove gulp altogether. I'm testing the installation and running time of grommet check && grommet pack and the improvement so far is impressive. About 35% faster installation time and 30% package time improvement.

alansouzati commented 7 years ago

The result of this investigation has been merged into grommet-cli, check it out:

https://github.com/grommet/grommet-cli/pull/10

RyanCCollins commented 7 years ago

Nice job on the merger! The new commands work great!

alansouzati commented 7 years ago

Thanks for the feedback @RyanCCollins