search

grommet / grommet-cms-boilerplate

Grommet CMS Boilerplate
Apache License 2.0
12 stars 3 forks source link

Feat rc complex layout engine #64

Closed RyanCCollins closed 7 years ago

RyanCCollins commented 7 years ago

Add a complex layout engine for setting content layout.

Note this is fairly experimental, but seems to be working really well in my opinion. @karatechops please do let me know if anything is not working as expected. I expect to have to iterate a bit on it. One thing that I would like to do is identify the default properties that should be set when creating a section or a content block and possibly even make that conditional on the content block, that way we are not hardcoding any layout properties into the content blocks themselves. I would also like to determine some layout presets we can use, but of course that is not a priority right now.

RyanCCollins commented 7 years ago

ETA: I also fixed the vexing $FlowFixMe issue and merged that into this branch, as well as added the babel react propType plugin so we can auto generate react propTypes from our flow types.

karatechops commented 7 years ago

Great work on this PR. The advanced layout engine seems to be working very well. I have not tested all combinations as that would probably take me all day. 😃 I'm sure we'll cover most combinations during our next project with the CMS. 👍