search

grommet / grommet-site

Site for Grommet v2
Apache License 2.0
32 stars 64 forks source link

add dataSearch `as` TextInput #492

Closed britt6612 closed 10 months ago

britt6612 commented 10 months ago

Added in the docs that 

DataSearch is a [TextInput](http://localhost:8567/textinput). You can customize it using the properties available in TextInput.

We have this wording already so just utilized this. In DataSearch.js in grommet we have 

      icon={<Search />}
      type="search"

for the TextInput prop however being that this is a DataSearch hence Search the keyword not sure if we should add these in the docs as default open to suggestions

taysea commented 10 months ago

I'm personally comfortable leaving as is and don't necessarily feel the icon/type are needed right now.