search

grommet / grommet-site

Site for Grommet v2
Apache License 2.0
32 stars 64 forks source link

remove routed button for grommet site #497

Closed Sulaymon333 closed 9 months ago

Sulaymon333 commented 9 months ago

Remove reouted button in favour of Button from grommet v2. Button component is now in use for grommet-site

jcfilben commented 9 months ago

Looks like there is some confusing naming going on here. We have a grommet component RoutedButton that is exported from grommet that has been deprecated.

In addition we have a RoutedButton component defined that is local to the grommet-site project. This RoutedButton is fine to keep.

We should remove the RoutedButton that is imported from 'grommet' so that we are not using deprecated components in our projects.

More info on why RoutedButton (from grommet) was deprecated: https://github.com/grommet/grommet/issues/2855

MikeKingdom commented 9 months ago

So given Jessica's clarification, the only file that needs to be changed is Examples.js which is the only one using RoutedButton from Grommet. And how that one should be changed depends on what it's trying to provide an Example of. And I actually can't find anywhere Examples.js is used

Sulaymon333 commented 9 months ago

Yes, Example.js is not used at all, it is not part of the routed pages either, there is no direct way/button to navigate to it. Do we still need to keep it in grommet-site?