Closed coltonw closed 8 years ago
makes fully sense, sorry for missing that. if it is a direct dependency it should be inside package.json.
Starting with NPM 3 all dependencies are flat, I'm guessing in your CI you have NPM 2 and locally you have NPM 3.
That was exactly the issue. I figured it out a bit later but thanks for taking the change. If figured it was just goodness.
I am not confident in my npm-fu, but it seems like since you are directly using yargs in this repo, it should be a direct dependency. Currently it is an indirect dependency because some of your dependencies have it as a dependency but it seems fragile to rely on that and possibly broken in some cases.
The reason this came up is that when I was trying to automate my grommet ui build, it failed with the following error:
I cannot reproduce the error locally and so am not sure how to test this fix, but thought this might be goodness anyways.
Sorry for the super long-winded pull request description for a one line change!