Button tip string should be used for a11yTitle default value if none provided

[samuelgoff]

Buttons and icon Buttons quite often need a tip value and a11yTitle value that is (or could suitably be) identical. The result is you end up repeating yourself, or declaring a const just so you only have to repeat the reference rather than the literal (or derivation), but it's still redundant.

Expected Behavior

If Button tip attribute is populated with a string but a11yTitle is not, then a11yTitle should get default value from the Button tip value. Not only does this solve a DRY opportunity, but this also ensures that if the a11yTitle value isn't populated, it will still allow the component to add a useful/meaningful aria-label value, improving accessibility with no additional effort on the part of the developer.

Actual Behavior

Create a Button and populate tip with a string but omit supplying an a11yTitle value, then elicit Tip visibility so you can examine the DOM. Note that the aria-label is not populated in the resulting button DOM.

URL, screen shot, or Codepen exhibiting the issue

https://codesandbox.io/s/grommet-v2-template-forked-w597x?file=/index.js

Steps to Reproduce

1. Create a Button
2. populate tip with a string but omit supplying an a11yTitle value
3. elicit Tip visibility so you can examine the DOM
4. Note that the aria-label is not populated in the resulting button DOM.

Your Environment

• Grommet version: grommet@2.17.1
• Browser Name and version: Chrome Version 89.0.4389.114 (Official Build) (x86_64) & Safari Version 14.0.3 (16610.4.3.1.7)
• Operating System and version (desktop or mobile): macOS Big Sur Version 11.2.3

[ShimiSun]

I like this enhancement idea! The code contribution for this enhancement should be straightforward, would you like to take a stab at it? @samuelgoff

[samuelgoff]

Thanks Shimi, I already have it done & PR ready, but the battery on my laptop died before I could submit. Trekking home from getting the COVID vaccine, then I’ll be able to plug in & submit the PR.

Thanks,

Sam

Sent from my iPhone

On Apr 8, 2021, at 1:47 PM, Shimi @.***> wrote:

 I like this enhancement idea! The code contribution for this enhancement should be straightforward, would you like to take a stab at it? @samuelgoff

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[samuelgoff]

I like this enhancement idea! The code contribution for this enhancement should be straightforward, would you like to take a stab at it? @samuelgoff

Hi @ShimiSun, hopefully this works for you.