Open eddieshowcase opened 2 years ago
FWIW - has the design team consider not styling these labels lighter, and rather style the input perhaps with ‘background-contrast’ to indicate its disabled instead? Right now when disabled the text labels are so light there has been concern or vocalized opinions that there isn’t enough contrast against the background to read the labels. Might be better to leave the labels alone and style the inputs as grayed-out instead. Just a thought…
This is still an issue and should be resolved: https://v2.grommet.io/formfield?c=DwMQ9gTgtiCWCmAbAJgAkQQwEZILwCI4k1MdF9UALJABwIGUwp4AXS2AOwHMLOAzMAyat23CslgBnbInjIAfAChUqYABV4ADxYBJDjQCuLVDUwBjeJTAp4EAiwCeNeFVvxxUmXNQB6JcB9waCIUeSA
FormFields/Inputs…. in your Figma files, you show disabled variants for inputs, the borders, labels, values all become lighter in style to show as disabled (but there are no examples of this variant with help/info text). I noticed that when any ‘help’ or ‘info’ text is provided in FormField component, these are not lightened when disabled. Is this the intended style for a disabled field with additional text? Perhaps a defect? Perhaps Figma file should show full examples with helper/info text for variant states? Should help/info text be hidden when disabled?
Is this issue related to the design system core library or design system website?
design-system-core, FormField Grommet component and HPE design system theme.
Expected Behavior
When disabled, I would expect the 'help' and 'info' text to also be styled lighter to match label and other disabled style queues.
I would also expect Figma examples to provide such use cases of variants with 'help' and 'info' text present.
Actual Behavior
The 'help' and 'icon' text remains enabled and appears dark in black text.
URL, screen shot, or CodeSandbox exhibiting the issue
Steps to Reproduce
Your Environment