grommet / hpe-design-system

HPE Design System
48 stars 24 forks source link

Notification Colors - Icon colors against notification background colors don't meet accessibility #2446

Closed KennyAtHPE closed 4 days ago

KennyAtHPE commented 2 years ago

Related to #2425

image Text color - default text Background colors - Validation Warning, Validation Critical, Background Contrast, Validation OK Status icon colors - Status Warning, Status Critical, Text Strong, Status OK

Concerns relating to the current dark mode validation and status colors:

This is affecting use cases such as global banners and form validation

Updated Success Criteria

vavalos5 commented 2 years ago

@KennyAtHPE Were there colors you had explored as alternative colors for this ticket?

KennyAtHPE commented 2 years ago

@vavalos5 there's a very small amount of exploration here. The colors used here are all already within our current color palette. Ultimately, we moved away from this exploration since we didn't want to use different existing colors but instead are advocating that the highlighted colors within this ticket be changed instead.

vavalos5 commented 2 years ago

Thanks Kenny. Once Chris returns, i'll chat w/ him on this matter. If it's a priority @SOjaHPE

vavalos5 commented 2 years ago

Chatted w/ Chris, here's his feedback: We should do more research and data on colors "not to be so rainbow-ish" - we can bring colors up and down question whether we are making the styles aligned to code and that it should react like the coded component

vavalos5 commented 2 years ago

An idea I came across which we can possibly consider Screen Shot 2022-04-15 at 2 13 41 PM

https://aui.atlassian.com/aui/8.1/docs/messages.html

vavalos5 commented 2 years ago

Sherry Mead reached out today to see if we have a solution. Don't know if we want to bump this up

SmWorkGitHub commented 2 years ago

Just wanted to repeat the issue description I gave Vicky in Figma. It applies to light and dark mode validation colors:

I'm going to be asking the owners of a UI component library to change the validation behavior of their form components and they will push back on semi transparent form field backgrounds for the reason Matt gave.

They can't control what teams do with their components so the components have to be readable and pass accessibility even if teams place them on colored or patterned backgrounds.

This is Sherry Mead. Sorry about the crappy user name.

ericsoderberghp commented 1 year ago

These colors were updated as part of https://github.com/grommet/grommet-theme-hpe/pull/280. We should re-check if the issue still exists.

taysea commented 2 months ago

@KennyAtHPE @oliverHPE before I close this, can you assess the current values and confirm if we've resolved this issue?

oliverHPE commented 2 months ago

Thanks @taysea Have found several colours for each validation type and need to confirm which are the latest. Will update you when these have been confirmed.

KennyAtHPE commented 2 months ago

@taysea @oliverHPE I've reviewed all the different states within our notifications and here's what I've found:

WCAG states "if the icons are required to understand the content, then the icons need to have a contrast ratio of at least 3:1." Link to docs. I suggest we reformat this ticket with this new scope in mind.

oliverHPE commented 2 months ago

@taysea Thanks @KennyAtHPE Also had a look at our status colors as measured against validation backgrounds in the light theme, and these also do not meet a 3 : 1 contrast ratio.

luketa8 commented 2 weeks ago

Updating:

Tagging @oliverHPE, @KennyAtHPE and @SeamusLeonardHPE for visibility

luketa8 commented 1 week ago

Updating Success Criteria:

luketa8 commented 1 week ago
jcfilben commented 1 week ago

Can we also run the new notification colors by Chris, Joelle, and Ashley to give them visibility?

luketa8 commented 1 week ago

Thanks Jessica. I 've sent a Slack message to @joellegregory.

luketa8 commented 5 days ago

From Joelle:

Everything looks great—Chris was happy with the proposed colors

luketa8 commented 4 days ago