search

grommet / hpe-design-system

HPE Design System
48 stars 24 forks source link

Grommet dependencies #2771

Open britt6612 opened 2 years ago

britt6612 commented 2 years ago

babel-jest, 28.1.2 -> 28.1.3 jest-cli, 28.1.2 -> 28.1.3 jest-environment-jsdom, 28.1.2 -> 28.1.3 jest 28.1.2 -> 28.1.3 testing-library/dom 8.14.0 -> 8.16.0 testing-library/user-event 14.2.1 -> 14.3.0

While trying to upgrade testing-library this was causing an error that 

React Testing Library and the “not wrapped in act” Errors

All of the tests it was flagging were using user.click which states that you do not need to wrap in act since this was just released 20 days ago we are holding off on this

Trying to upgrade jest was causing snap shot changes depending on which node version you are on so holding off on these changes so we do not break snapshots.

britt6612 commented 2 years ago

Update can not upgrade the following: ❯◯ @testing-library/dom latest 8.18.0 ❯ 8.18.1 https://github.com/testing-library/dom-testing-library#readme ◯ babel-plugin-styled-components latest 2.0.6 ❯ 2.0.7 https://styled-components.com/docs/tooling#babel-plugin ◯ del latest 6.1.1 ❯ 7.0.0 https://github.com/sindresorhus/del#readme ◯ jest-styled-components latest 7.0.5 ❯ 7.1.1 https://github.com/styled-components/jest-styled-components#readme

ericsoderberghp commented 2 years ago

What's preventing us from updating del?

britt6612 commented 2 years ago

What's preventing us from updating del?

With the new release, they are moving directly to ESM and no longer supporting CommonJS support. This would mean that we need to move our CommonJS project to ESM. Which would change some of our package.json.. We cannot do this yet because some of our packages are not defined in ESM.