search

grommet / hpe-design-system

HPE Design System
48 stars 24 forks source link

CheckBox Group - Revisit keyboard interactions #2883

Open vavalos5 opened 2 years ago

vavalos5 commented 2 years ago

Currently, checkbox keyboard interactions are:

tab - CheckBox Group receives focus tab - First item is highlighted tab - Next item is highlighted

I think we should revisit the keyboard interactions to align with List and DataTable where the user should be able to maneuver up/down the list items within the CheckboxGroup while the CheckBox Group is in focus. Using tab should take the user to the next interactive item on the page. That goes along with RadioButton Group.

halocline commented 2 years ago

FYI, checkbox and radio button group keyboard interactions are well established in native HTML. We need to keep those in consideration when evaluating as we may not want to deviate from some long established norms.

vavalos5 commented 2 years ago

FYI, checkbox and radio button group keyboard interactions are well established in native HTML. We need to keep those in consideration when evaluating as we may not want to deviate from some long established norms.

Yea, I agree. I think the tab order we currently makes sense if they weren't grouped with a border around the checkbox. Would love to test this with Bill and see if this behavior makes sense to him.

jcfilben commented 2 years ago

Related to https://github.com/grommet/hpe-design-system/issues/2664