StyledComponents - RESEARCH SPIKE - Create styled components plan of attack

taysea commented 1 year ago

As we've begun migration to styled-components v6, there are more considerations to take into account than initially expected.

Current progress/notes captured here: https://docs.google.com/document/d/1SLnJLBdVdpBByUTPaCzlwKksViRl9Q_cZ1yagnU7C7o/edit?usp=sharing

Deliverables:

[ ] Clarity on approach for adopting v6, order of components/number of components per sprint/plan for pre-release/communications/etc.
[ ] Any follow-on tickets filed

Questions:

[ ] Can we make the props that should be transient behavior more like private variables?
[ ] Should we continue moving forward with styled components?
[ ] Should we evaluate other CSS solutions?

jcfilben commented 1 year ago

Update 7/27: Discussed as a dev team and decided the next step for us to take is to try upgrading to v6 of styled components, but opt into v5 behavior using StyleSheetManager. From there evaluate what effect this has for people consuming grommet with styled components v6. Do features like @container work?

jcfilben commented 5 months ago

Closing, we have an agreed upon direction for styled components here https://github.com/grommet/grommet/pull/7165

grommet / hpe-design-system

StyledComponents - RESEARCH SPIKE - Create styled components plan of attack #3476