grommet / hpe-design-system

HPE Design System
48 stars 24 forks source link

ToggleButton - Review toggle button group template - Additional use cases & candidate for component. #3611

Open SeamusLeonardHPE opened 11 months ago

SeamusLeonardHPE commented 11 months ago

Based on feedback from template library.

Should the toggle button group be open to use cases outside of the data collection toolbar.

https://www.figma.com/file/fupkQ4sOefx3qUVoV6WfJi/Template-Library?type=design&node-id=37-5272&mode=design&t=fMXLjgSoXD0lkLGG-4

WIP file

Relavant tickets https://github.com/grommet/hpe-design-system/issues/3432 https://github.com/grommet/hpe-design-system/issues/3493

ashifalinadaf commented 10 months ago

Success criteria

SeamusLeonardHPE commented 10 months ago

@ashifalinadaf consider that this is most likely a custom styled version of a checkbox multi-select or radio button group

radio-button-group "A styled select list that can have a single entry checked at any one time.: https://www.lightningdesignsystem.com/components/radio-button-group/

Checkbox Button Group A styled checkable input group that communicates if an option(s) are true, false or indeterminate https://www.lightningdesignsystem.com/components/checkbox-button-group/

On consideration I don't think this should be related to the button component (other than in styling similarity)

halocline commented 10 months ago

@ashifalinadaf consider that this is most likely a custom styled version of a checkbox multi-select or radio button group

radio-button-group "A styled select list that can have a single entry checked at any one time.: https://www.lightningdesignsystem.com/components/radio-button-group/

Checkbox Button Group A styled checkable input group that communicates if an option(s) are true, false or indeterminate https://www.lightningdesignsystem.com/components/checkbox-button-group/

On consideration I don't think this should be related to the button component (other than in styling similarity)

I'd like to get an initial brainstorm of considerations for this. Please schedule a cross-functional kickoff session to discuss use cases, semantic considerations, etc.

For example:

ashifalinadaf commented 10 months ago

Please have a look at the initial findings and suggestions @halocline @taysea Figma file initial inputs can be helpful.

WIP file

SeamusLeonardHPE commented 9 months ago

Created ticket to request coded prototype:

https://github.com/grommet/hpe-design-system/issues/3642

ashifalinadaf commented 8 months ago

Guidance is under draft requested for designers review.