grommet / hpe-design-system

HPE Design System
48 stars 24 forks source link

Form and Center layer button placement conflict<insert title> #3766

Open gregfuruiye opened 9 months ago

gregfuruiye commented 9 months ago

Link to problem

https://design-system.hpe.design/templates/forms

Current problem

The center layer component specifies buttons to be placed bottom and right aligned. Form shows buttons bottom and left aligned (except for the Single required FormField example). So if my form is in a center layer, then are my buttons left or right aligned? Side drawer layer specifies buttons left aligned.

My opinion is that buttons are left aligned in all conditions (center layer, side drawer layer, forms, etc...). I believe this progression helps with accessibility concerns, keyboard navigation and helps avoid confusion in the documentation.

Also, the Figma component for CenterLayer contains a close icon for the actionable variant. In keeping with the documented guidance on the Design System website, this close icon should not be available for the actionable variant, it needs to be removed.

Expected behavior or solution

Buttons are left aligned in Centerlayer, SideDrawerLayer, Forms, ... Guidance on the design system site and examples are consistent and clearly stated. Figma component variants are accurate.

Screenshot or recording of problem

image

Steps to reproduce

No response

gregfuruiye commented 9 months ago

image