grommet / hpe-design-system

HPE Design System
48 stars 23 forks source link

PAGINATION - Write Documentation #3777

Closed SeamusLeonardHPE closed 1 month ago

SeamusLeonardHPE commented 6 months ago

Who is requesting this? (add contact details here) Internal

What is the problem this ask is trying to solve? No documentation for new component called Pagination.

Branch with latest design: https://www.figma.com/file/tlRprPDp1yY1AaSOhoiiSH/%233651---Pagination-component?type=design&node-id=26125-326&mode=design

Anatomy to form basis of documentation: https://www.figma.com/file/nxI308Yvt4HKJ1rjgrEXCk/%233651---Pagination-Component?type=design&node-id=6-385&mode=design&t=eHf2uaQ7Zaxkz38m-4

Imported design system site page to figma to mock up edits outside of code: https://www.figma.com/file/nxI308Yvt4HKJ1rjgrEXCk/%233651---Pagination-Component?type=design&node-id=330-6294&mode=design&t=eHf2uaQ7Zaxkz38m-4


Reviewers:

List possible consequences, involved assets and components: 1

Define MVP for this ticket (format, amount of detail, where it should live, etc):

Follow up tickets: (if necessary) 1 2 3

Checklist (add your progress in the comments)

SeamusLeonardHPE commented 2 months ago

@taysea could you please review and add some notes of my first draft of the pagination update.

Based on the new format from togglegroup Ive tried to reduce the copy and specify usage in the anatomy notes.

https://www.figma.com/design/nxI308Yvt4HKJ1rjgrEXCk/%233651---Pagination-Component?node-id=414-7939&t=0JoCySy7pyxFKIhu-4

SeamusLeonardHPE commented 1 month ago

Added a first draft into a PR, will need de help to create

1- Default pagination view (all settings exposed) 2- table examples for anatomy 3- Responsive fullscreen demo versions

SeamusLeonardHPE commented 1 month ago

PR link https://github.com/grommet/hpe-design-system/pull/3984

Requested input from @britt6612 and @vavalos5 re code examples

SeamusLeonardHPE commented 1 month ago

Deploy preview https://deploy-preview-3984--keen-mayer-a86c8b.netlify.app/components/pagination

Meeting with Julia on Monday to make final edits & fit new site page format.

SeamusLeonardHPE commented 1 month ago

Closed as updated have been merged into master.

https://github.com/grommet/hpe-design-system/pull/3984#event-13701661012