grommet / hpe-design-system

HPE Design System
48 stars 23 forks source link

Add clear propery to Select Figma component and Guidance #4068

Open luketa8 opened 1 month ago

luketa8 commented 1 month ago

What does this request relate to?

Figma, Guidance site

Describe the feature you'd like to request.

The clear property exists in Grommet and in code.

This is not reflected in the Select Figma component and the Select guidance page.

The clear property is useful for single selection in filtering scenarios, where a blank filter is a valid option.

Links to Figma files with use cases or ideations from you.

Exploration branch (Outdated, archive when component is updated) Current Branch

How urgent is this request?

None

Is there anything else you would like to mention?

No response

KennyAtHPE commented 1 month ago

Branch file

@SeamusLeonardHPE @luketa8 currently updating the component and ran into some issues. No blockers but feel free to review the current WIP if available. I left notes and questions throughout.

List of changes so far:

SeamusLeonardHPE commented 1 month ago

@KennyAtHPE @luketa8

added an experiment that included multi option choice & fixes the absolute position issues:

https://www.figma.com/design/bqkEbdj8hZUBO9eQAmXnhV/%234068---Add-'Clear-Selection'-to-Select?node-id=35367-3831&t=S7Jjn6EjHRg1RFsf-4

KennyAtHPE commented 1 month ago

Current Branch Log of changes

Remaining questions + deliverables

KennyAtHPE commented 1 month ago

Future tickets:

SeamusLeonardHPE commented 3 weeks ago

@KennyAtHPE when you get a chance to visit this again can you focus on

in order of importance 1- Clear button styling (in all states) - Lets get exampled visible on the canvas to discuss our options. 2- Discuss with dev & designers about use of subcomponent or customised "button" 3- Max amount - lets add guidance in the component metadata for now - We can discuss how to engineer "drop" with overflow subsequently for our input refactor work" 4- Draft Guidance

KennyAtHPE commented 1 week ago

Reach out to Antonio Laccarino once the select component has been updated. image

SeamusLeonardHPE commented 3 days ago

@KennyAtHPE can you summarize the MVP design deliverables that you presented last week, and we can discuss getting an issue on the dev board to follow up.

My recollection was that we were not going to enhance the functionality at the moment 1- Style the clear button to meet contrast accessibility 2- Draft guidance

KennyAtHPE commented 3 hours ago

@SeamusLeonardHPE Here are the current explorations

MUST CHANGE

Acceptance Criteria

Conclusions based on feedback received: Styling

Image Here are some additional explorations on styling

Behavior

Misc.

Next steps