Notification - Build discovery - Githubissues

grommet / hpe-design-system

HPE Design System

48 stars 24 forks source link

Notification - Build discovery #4243

Open SeamusLeonardHPE opened 2 weeks ago

SeamusLeonardHPE commented 2 weeks ago

Working in the v2 library apply tokens to the notification component.

https://www.figma.com/design/5NUO23O2mDjiulO2H0S2Os/v2-Construction-Site?node-id=2168-1437

[ ] Create branch specific to this issue
[ ] Replace existing styles with tokens
[ ] Note any missing tokens or unused tokens related to state

luketa8 commented 2 weeks ago

Updated three notifications components with Tokens and added a few observations:

Not sure what the (1) means. It appeared when I added the underline decoration to the anchor.medium Token

I modify this Fill but it keeps going back to Light/Text. Is this a Figma bug due to having multiple styles in the same layer?

Screenshot 2024-10-10 at 5 54 08 PM

I had trouble finding the right token here. I think it should be text.medium.medium, is there a reason that I'm missing?