search

grommet / hpe-design-system

HPE Design System
48 stars 24 forks source link

Header Cell - Code Parity Review #4464

Open CillianHPE opened 3 days ago

CillianHPE commented 3 days ago

Link to Figma

Figma Build Review Code Parity Review Tokens Review

CillianHPE commented 15 hours ago

Feedback and answers from Slack

Table Header Cell Type Selectable should this also include focus under the state? For the alpha release, we have decided to exclude the focus state from the header and data cells, as including it would significantly increase the scope of work.

Sortable —> is that the correct icon? Looks really bold Currently, the sort icons appear bolder and larger compared to the version in V1. We have decided to keep them as they are for now and address this once the appropriate icons are introduced in the V2 icon library.