halocline
commented
4 years ago 👍
On Wed, Mar 25, 2020 at 5:07 PM Shimi notifications@github.com wrote:
Some icons we are using on the design-system-site would not be placed on Grommet-icons repo. hence we need to organize those resources on a separate repo within the monorepo. The icons could be shared between the site and the core library.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hpe-design/design-system/issues/581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANM6FGJW4Q5DAN4RMKRM5LRJKFBLANCNFSM4LT2CXXA .
Update context: We no longer need a repo for the icons since we did an extensive work of adding icons to grommet icons. Though, the next step for the design-system would be to clean up the icon files (svg+js) from the site repo and refer to the new icons on the grommet-icons stable instead. This would light-up the site package.
Some icons we are using on the design-system-site would not be placed on Grommet-icons repo. hence we need to organize those resources on a separate repo within the monorepo. The icons could be shared between the site and the core library.