search

gromo / jquery.scrollbar

jQuery CSS Customizable Scrollbar
GNU General Public License v2.0
756 stars 238 forks source link

improve several point：umd, angular, IIFE #40

Closed e-cloud closed 9 years ago

e-cloud commented 9 years ago
  1. add umd wrapper to the plugin
  2. improve angular support (no test yet)
  3. wrap the updateScrollbars function into IIEF
gromo commented 9 years ago

Hello. Thank you for your commit. I will review it and merge after test.

But I have few questions: as I can see I should switch doc and win in arguments (because of root, root.document order), is it correct? Also, you set angular as dependency, what will happen if angular won't be loaded?

e-cloud commented 9 years ago

that is a question, i haven't think about if angular is not provided. i need time to figure out!

e-cloud commented 9 years ago

I just push another commit, it fixed the argument order bug, and remove the angular dependency. As a result, when someone wants to use it with AngularJS and RequireJS together, he need to add a shim anyway. But if no angular dependency, no shim is required!