Moved LightMap update - Githubissues

grondag / darkness

Hardcore darkness for Fabric mod loader

GNU Lesser General Public License v3.0

13 stars 27 forks source link

Open Celivalg opened 1 year ago

Celivalg commented 1 year ago

Moved LightMap update to invoke of DynamicTexture.upload() inside LightTexture.updateLightTexture()

This allow other mods to get the LightMap after TrueDarkness updates it (aka DH, see #30 )

Tested on 1.19.2 on both Forge and Fabric

As a consequence, the MixinDynamicTexture is not needed at all anymore, this streamlines the code a bit more.

I couldn't make the 1.19 branch build and I don't know what's up with it, but 1.19.2 worked fine so here I am

Taleuxss commented 1 year ago

wonderful change @Celivalg

HaXrDEV commented 9 months ago

Great work! Hope you don't mind me implementing this change into my updated fork.