search

grondilu / libdigest-raku

Raku implementation of various digests
Artistic License 2.0
27 stars 42 forks source link

failing zef install (no useful info) #29

Closed masukomi closed 2 years ago

masukomi commented 2 years ago 
    ===> Testing: Digest:ver<0.18.5>
    ===> Testing [FAIL]: Digest:ver<0.18.5>
    Aborting due to test failure: Digest:ver<0.18.5> (use --force-test to override)

macOS: 12.6 Monterey

❯ rakudo --version
Welcome to Rakudo™ v2022.07.
Implementing the Raku® Programming Language v6.d.
Built on MoarVM version 2022.07.
lizmat commented 2 years ago

I think this is caused by the Digest module having a CHECK block that does a plan 1, which causes:

% zef install Digest --verbose --/rea
===> Searching for: Digest
===> Found: Digest:ver<0.18.5> [via Zef::Repository::LocalCache]
===> Testing: Digest:ver<0.18.5>
[Digest] t/digest.t .. All 1 subtests passed 
[Digest] t/ripemd.t .. ok
[Digest] t/sha.t ..... ok
[Digest] All tests successful.
[Digest] 
[Digest] Test Summary Report
[Digest] -------------------
[Digest] t/digest.t (Wstat: 0 Tests: 8 Failed: 0)
[Digest]   Parse errors: Seen a second plan
[Digest]                 Tests out of sequence.  Found (1) but expected (2)
[Digest]                 Tests out of sequence.  Found (2) but expected (3)
[Digest]                 Tests out of sequence.  Found (3) but expected (4)
[Digest]                 Tests out of sequence.  Found (4) but expected (5)
[Digest]                 Tests out of sequence.  Found (5) but expected (6)
[Digest]                 Tests out of sequence.  Found (6) but expected (7)
[Digest]                 Tests out of sequence.  Found (7) but expected (8)
[Digest]                 Bad plan.  You planned 1 tests but ran 8.
[Digest] Files=3, Tests=19,  2 wallclock secs
[Digest] Result: FAILED
===> Testing [FAIL]: Digest:ver<0.18.5>
Aborting due to test failure: Digest:ver<0.18.5> (use --force-test to override)

the first time it's run, because then the module is precompiled, and only then is CHECK block run an inappropriate time.

grondilu commented 2 years ago

Commit 6ad0135dc3da5f5b8be0dfb3d5171126d8c5c995 likely solved the issue.

I will close upon confirmation.

lizmat commented 2 years ago

Looks ok to me now :-)

% zef install Digest 
===> Searching for: Digest
===> Updating fez mirror: https://360.zef.pm/
===> Updated fez mirror: https://360.zef.pm/
===> Updating rea mirror: https://raw.githubusercontent.com/Raku/REA/main/META.json
===> Updated rea mirror: https://raw.githubusercontent.com/Raku/REA/main/META.json
===> Testing: Digest:ver<0.18.6>
===> Testing [OK] for Digest:ver<0.18.6>
===> Installing: Digest:ver<0.18.6>