grondilu / libdigest-raku

Raku implementation of various digests
Artistic License 2.0
27 stars 42 forks source link

version mismatch #38

Closed AntonOks closed 11 months ago

AntonOks commented 1 year ago

WARNING: Version mismatch for Digest ("https://github.com/grondilu/libdigest-perl6.git") found. META6.json has "1.0.1" but latest 'git tag' is "1.0.0"

grondilu commented 1 year ago

I added a tag in #37. I guess I incremented the version number in the META6.json since then. Was I supposed to do it to the tag, too?

I have no clue how these things work, and tbh I'm not too enthusiastic about learning about it. Seems like a major hassle.

AntonOks commented 1 year ago

Hi @grondilu

First of all, thanks a lot for your efforts and help!

As I wrote in #37, it would be great if you add a "git tag" whenever you release a new version of your software, say update your "version" key in your META6.json and commit this kind of change.

Back to our topic #38 here...

  1. You do already obviously use "git". And also you do use "git commit" and add nice commit messages. So sometimes you "bumb versions" already today and lucky-wise document it in your commits with a perfect fitting message :)

    Now, there is only one little step missing to have the "git versioning" pest practices in place.... whenever you do a "git commit" today, please do a "git tag <version***> in addition / the future. THAT WOULD BE IT! _*version_** for Rakudo module developers should be exactly the same as the new one in META6.json ;)

  2. To add a tag later ( so now ;) ), you can please run git tag -a 1.0.1 f71ccf9, which add a a new tag "1.0.1" to your commit, where you bumped your version. Then, please also please remember to push the new tag(s) by git push --tags to your "remote", aka GitHub here.

    [2] / this is NOT needed if you once tag your commits already before pushing them, see [1] above!

Thanks again!

2colours commented 1 year ago

@grondilu and while you are at it, could you also do a fez upload?

grondilu commented 1 year ago

@grondilu and while you are at it, could you also do a fez upload?

fez is asking me for a login/password? I don't remember needing this.

Nevermind I found the password.

AntonOks commented 11 months ago

Module version was increased to 1.1.0 in META6.json in https://github.com/grondilu/libdigest-raku/commit/8f717270aca63a3b6900f123860cd017fc7b3a86, but there is no such "git tag", again.

Can you please add a tag v1.1.0, which refers to commit 8f717270? THANKS!

grondilu commented 11 months ago

Module version was increased to 1.1.0 in META6.json in 8f71727, but there is no such "git tag", again.

Can you please add a tag v1.1.0, which refers to commit 8f71727? THANKS!

Should be done now. I was not sure the 'v' prefix was necessary, though. I did :

$ git pull
$ git tag 1.1.0
$ fez upload
AntonOks commented 11 months ago

Module version was increased to 1.1.0 in META6.json in 8f71727, but there is no such "git tag", again. Can you please add a tag v1.1.0, which refers to commit 8f71727? THANKS!

Should be done now. I was not sure the 'v' prefix was necessary, though. I did :

$ git pull
$ git tag 1.1.0
$ fez upload

That's almost right :| FEZ is not git, so your last line, aka fez upload, is NOT uploading your GIT TAGs to your GIT REMOTE, aka GitHub | this repo here.

As I wrote above in https://github.com/grondilu/libdigest-raku/issues/38#issuecomment-1714504427, the correct sequence usually is:

1. cd <your-local-git-repo-path>
2. git pull -a
3. git tag -a 1.1.0 8f71727
4. git push --tags

As you have already added the 1.1.0 tag above, you should either check and assure it's pointing to commit 8f71727. If it's not pointing to this but another commit, you should delete the git tag, locally and remote, and then re-add and push it remote again, see steps 3 and 4 above.

THANKS again!

grondilu commented 11 months ago

That should be it now, right?

https://github.com/grondilu/libdigest-raku/releases/tag/1.1.0

AntonOks commented 11 months ago

That should be it now, right?

https://github.com/grondilu/libdigest-raku/releases/tag/1.1.0

YES, THANK YOU very much!